Skip to content

Use logic and to chain apt commands in QA Dockerfile

vincent stchu requested to merge gitlab-jh/jh-team/gitlab:make-suer-docker-build-quit-when-apt-command-fails into master

What does this MR do and why?

This MR fixes the issue that QA image build continues even if the apt installation fails at https://gitlab.com/gitlab-jh/jh-team/gitlab/-/blob/5ce051e5efa0af420b65ddb318b3aa3aec74c4ce/qa/Dockerfile#L18 because the last rm command is always successful.

Use && (logic AND) to chain these commands so that the docker build exits with failure once any of them fails.

Screenshot

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports