Skip to content

Use let_it_be instead of let in Pipeline test

Tetiana Chupryna requested to merge brytannia-pipeline-test-improvement into master

What does this MR do and why?

I noticed that we don't use let_it_be for creating pipeline in ee/spec/models/ci/pipeline_spec.rb so I fixed it. I added refind option, as one of the test failed. As well, I've changed let to let_it_be in dependency_list_reports as that was my initial goal.

with let

Finished in 42.68 seconds (files took 17.48 seconds to load)
127 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:27.495 (61.93% of total time)

with let_it_be

Finished in 37.79 seconds (files took 11.67 seconds to load)
127 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:24.414 (63.34% of total time)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tetiana Chupryna

Merge request reports