Migrated branches_dropdown and projects_dropdown to GlCollapsibleListbox
What does this MR do and why?
This migrates GlDropdown in app/assets/javascripts/projects/commit/components/branches_dropdown.vue to GlCollapsibleListbox (see #384280 (closed)).
Migrates GlDropdown in app/assets/javascripts/projects/commit/components/projects_dropdown.vue to GlCollapsibleListbox (see #386027 (closed)).
Screenshots or screen recordings
Screenshots for branches_dropdown.vue for #384280 (closed)
| Before | After |
|---|---|
 |
 |
 |
 |
 |
 |
Screenshots for projects_dropdown.vue for #386027 (closed)
| Before | After |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
- Navigate to project > commits
- Select a commit
- Select dropdown called "Options" in top right
- Select option "Cherry-pick"
- Migrated dropdown is the branch dropdown under heading "Pick into branch"
Details
As can be seen in the screen shots, there are some visual differences between the original and migrated dropdowns. I would love some feedback as to whether this is acceptable or not.
I reached out to @gitlab-org/manage/foundations/engineering with questions about this and that discussion can be seen in #384280 (comment 1207143572).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #384280 (closed), #386027 (closed)