Skip to content

Create new feature flag for product analytics admin settings

Robert Hunt requested to merge 385598-create-new-feature-flag-for-admin-settings into master

What does this MR do and why?

This MR updates the product analytics admin settings to use a dedicated feature flag rather than being tied to the new API. The reason for this is that the settings are global while the API is local. So for a staggered rollout we need to enable the settings for everyone but then limit the API and UI on a per user/project basis.

Screenshots or screen recordings

unchanged

How to set up and validate locally

  1. Visit admin settings and make sure that the settings are not shown: /admin/application_settings/general#js-product-analytics-settings.
  2. Enable the feature flag's: echo "Feature.enable(:product_analytics_admin_settings)" | rails c.
  3. Visit admin settings and make sure that the settings are shown and are saveable: /admin/application_settings/general#js-product-analytics-settings.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #385598 (closed)

Merge request reports