Do not dismiss webide callout when it is hidden
What does this MR do and why?
It fixes a bug in the New Web IDE callout. We are dismissing the callout by clicking the edit button even when the callout isn’t visible.
Screenshots or screen recordings
How to set up and validate locally
To reproduce the bug on master:
- Checkout the
master
branch - Disable
vscode_web_ide
feature flag in your local environment. - Click the Web IDE button on the Project Overview page.
- Go back to the Project Overview page.
- Enable the
vscode_web_ide
feature flag and reload. - You should not see the new Web IDE callout after enabling the
vscode_web_ide
feature flag.
To reproduce the solution:
- Checkout
do-not-dismiss-callout-if-hidden
- Delete the web_ide callout entry in the Rails console running this command:
Users::Callout.find_by(feature_name: "vscode_web_ide").delete()
. - Follow steps 3-6 from the previous list. You should see the Web IDE callout now.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Enrique Alcántara