Skip to content

Do not dismiss webide callout when it is hidden

Enrique Alcántara requested to merge do-not-dismiss-callout-if-hidden into master

What does this MR do and why?

It fixes a bug in the New Web IDE callout. We are dismissing the callout by clicking the edit button even when the callout isn’t visible.

Screenshots or screen recordings

Screen_Shot_2022-12-13_at_11.07.11_AM

How to set up and validate locally

To reproduce the bug on master:

  1. Checkout the master branch
  2. Disable vscode_web_ide feature flag in your local environment.
  3. Click the Web IDE button on the Project Overview page.

Screen_Shot_2022-12-13_at_10.59.17_AM

  1. Go back to the Project Overview page.
  2. Enable the vscode_web_ide feature flag and reload.
  3. You should not see the new Web IDE callout after enabling the vscode_web_ide feature flag.

To reproduce the solution:

  1. Checkout do-not-dismiss-callout-if-hidden
  2. Delete the web_ide callout entry in the Rails console running this command: Users::Callout.find_by(feature_name: "vscode_web_ide").delete().
  3. Follow steps 3-6 from the previous list. You should see the Web IDE callout now.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Enrique Alcántara

Merge request reports