Skip to content

Validate notification integrations channel limit

Luke Duncalfe requested to merge 383894-add-channel-validation-per-trigger-to-base-chat-notifications into master

What does this MR do and why?

This change adds a new validation to our Slack and Mattermost notification integrations that each event trigger is configured for at most 10 unique channels.

SaaS production data was inspected, and currently, the most an event trigger has been configured for is 7 channels (see Slack - internal, good for 90 days).

It also adds a tweak so we send to a unique list of channels, to avoid the ability for the integrations to post the same thing to the same channel.

Screenshots

image

QA

  1. Visit /<PROJECT>/-/settings/integrations/slack/edit.
  2. Enter in 10 channel names, separated by commas.
  3. The integration should save.
  4. Add an 11th channel name.
  5. The integration should not save, and a validation error should display.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #383894

Edited by Luke Duncalfe

Merge request reports