Skip to content

Property `browser_performance` is not allowed on `.gitlab-ci.yaml`

Stavros Ntentos requested to merge stdedos/gitlab:stdedos/383844/ci/schema/add-browser_performance into master

What does this MR do and why?

This MR adds browser_performance to app/assets/javascripts/editor/schema/ci.json, as it is missing.

Fixes: #383844 (closed) Rationale: #383844 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before:

image

After:

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

As per documentation https://docs.gitlab.com/ee/development/cicd/schema.html#verify-changes, using gdk.test is one self-sufficient, isolated way to test these kind of changes https://docs.gitlab.com/ee/ci/lint.html#check-cicd-syntax.

Also done in https://youtu.be/UpriK25RZiY.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stavros Ntentos

Merge request reports