Skip to content

Squash housekeeping period options into a single one

Igor Drozdov requested to merge id-squash-housekeeping-options into master

What does this MR do and why?

Related issue: #353778 (closed)

With the introduction of OptimizeRepository RPC some of the housekeeping options become redundant.

Currently, we have 3 options that are responsible for how often a particular optimization is called:

  • Incremental repack period: Number of Git pushes after which an incremental git repack is run.
  • Full repack period: Number of Git pushes after which a full git repack is run.
  • Git GC period: Number of Git pushes after which git gc is run.

With OptimizeRepository introduced, the frequency of a particular operation can't be controlled from Gitlab Rails anymore. Let's choose the lowest one out of these three (Incremental repack period) and use it as a value of how often OptimizeRepository is called.

Basically, this merge request replaces the three options on the UI with a single one in case self-hosted applications pay attention to these options. In case they have problems with the changes, they can disable the optimized_housekeeping feature flag.

Edited by Igor Drozdov

Merge request reports