Increase contrast ratio of buttons
What does this MR do and why?
Describe in detail what your merge request does and why.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Example 1:
- Post a comment on an MR diff
- Collapse/expand comment
Example 2:
- Assign a lot of people (I used 8) to a single issue
- Go back to main issue list and locate specific issue row
- Badge should appear in row
Example 3:
- Go go issue you just assigned 8 people to
- Collapse sidebar
- Badge should appear in
Assignees
section
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #384868 (closed)
Related to ✨ Beautifying our UI: Create:Code Review ✨ (#364574 - closed)
Merge request reports
Activity
assigned to @annabeldunstone
changed milestone to %15.7
added Category:Code Review Workflow UX accessibility frontend labels
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
added severity4 label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova (
@dzubova
) (UTC+1, 1 hour ahead of@annabeldunstone
)Zack Cuddy (
@zcuddy
) (UTC-6, 6 hours behind@annabeldunstone
)UX Sunjung Park (
@sunjungp
) (UTC+1, 1 hour ahead of@annabeldunstone
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@annabeldunstone - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a7ff9097 and 95576641
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.52 MB 3.52 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for a7ff9097. So we have used data from: ae8c830f.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Andy Volpe
added featureenhancement typefeature labels
requested review from @esybrant
added Beautifying our UI UI polish labels
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 95576641expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Govern | 15 | 0 | 5 | 3 | 20 | ❗ | | Manage | 39 | 0 | 4 | 7 | 43 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 152 | 0 | 15 | 10 | 167 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Olena Horal-Koretska
requested review from @ohoral
- Resolved by Annabel Dunstone Gray
- Resolved by Annabel Dunstone Gray
- Resolved by Annabel Dunstone Gray
removed review request for @esybrant
removed review request for @ohoral
Setting label(s) devopscreate groupcode review sectiondev based on ~"Category:Code Review" groupcode review.
added devopscreate groupcode review sectiondev labels
added 436 commits
-
ee5f4992...ef0ec97c - 435 commits from branch
master
- cda0d224 - Increase contrast ratio of buttons
-
ee5f4992...ef0ec97c - 435 commits from branch
added 213 commits
-
cda0d224...1856ec2f - 212 commits from branch
master
- 95576641 - Increase contrast ratio of buttons
-
cda0d224...1856ec2f - 212 commits from branch
requested review from @andyvolpe
@andyvolpe
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @ohoral and removed review request for @andyvolpe
@ohoral, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 128c3a8e
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
mentioned in issue #384868 (closed)
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)