Skip to content

Improve UX of `Clear status after` field

Peter Hegman requested to merge revert-2540db58 into master

What does this MR do and why?

Related to #372981 (closed)

Improves the UX of the Clear status after field that is shown when setting your status. Previously after setting this field it changed back to Never and showed the date it would clear below. This was confusing because it can look like it won't expire when it actually will. This MR removes the date below the dropdown and instead displays the date that it will expire as the dropdown button.

Note: This was previously reviewed by frontend and UX in !105611 (merged) but was accidentally merged before backend review and therefore reverted to be on the safe side. The UX of this MR has not changed but the frontend has changed a little bit because we are switching to the PATCH /user/status endpoint that we added in !107115 (merged). The reason for this is because the PUT /user/status endpoint that we were previously using does not allow us to update the status and emoji without clearing the Clear status after field. This causes UX problems. For more context see https://gitlab.slack.com/archives/C02PF508L/p1670869061302579

Screenshots or screen recordings

Modal

Before After
Untitled__3_ Untitled__5_

Profile

Before After
Untitled__4_ Untitled__6_

How to set up and validate locally

Modal

  1. Click your avatar in the upper right corner
  2. Select Set status

Profile

  1. Navigate to /-/profile

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports