Skip to content

Show locked icon only for project runner

Miguel Rincon requested to merge mrincon-runnner-locked-only-project-type into master

What does this MR do and why?

This change fixes an issue in which the locked icon was shown for group and shared runners. The "locked" attribute is only valid for project runners.

Changelog: fixed

Screenshots or screen recordings

before after
Screenshot_2022-12-12_at_15.10.11 image

How to set up and validate locally

We will verify how the runners are displayed, so we should first register an instance runner and a group runner. See https://docs.gitlab.com/runner/register/#requirements for more details

Once the runners are created:

  1. As admin or project owner/maintainer
  2. Visit the your project Runners page at My Project > Settings > CI/CD e.g. http://gdk.test:3000/top-group/top-project/-/settings/ci_cd
  3. Confirm the locked icon do not show for group or shared runners.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports