Move done button for to-dos on small devices
What does this MR do and why?
De-emphasizes the "Done" button for To-Dos on small devices.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mvanremmerden
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
mentioned in issue #385261 (closed)
- Resolved by Marcel van Remmerden
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mario Celi (
@mcelicalderonG
) (UTC-5)Jan Provaznik (
@jprovaznik
) (UTC+1)frontend James Rushford (
@jrushford
) (UTC+11)Coung Ngo (
@cngo
) (UTC+0)UX Camellia X. YANG (
@cam.x
) (UTC+0)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5da03669 and bb7f4311
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.5 MB 3.5 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for 5da03669. So we have used data from: d838929e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for bb7f4311expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Manage | 39 | 0 | 4 | 7 | 43 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Govern | 15 | 0 | 5 | 3 | 20 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 152 | 0 | 15 | 10 | 167 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
@v_mishra
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @v_mishra
- Resolved by Marcel van Remmerden
- Resolved by Marcel van Remmerden
- Resolved by Marcel van Remmerden
@cngo On to you for maintainer review
- Resolved by Marcel van Remmerden
- Resolved by Marcel van Remmerden
enabled an automatic merge when the pipeline for 7e0314b9 succeeds
mentioned in commit d65659c8
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)