Skip to content

Draft: Hide tags input for select scanners

Alexander Turinske requested to merge 382994-hide-tags-for-select-scanners into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Hide tags input for select scanners

  • some scanners do not allow tags, so the tags input should be hidden for those scanners
  • add tests

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Scanner Screenshot
DAST Screen_Shot_2022-12-11_at_19.22.47
SAST Screen_Shot_2022-12-11_at_19.22.54
CONTAINER SCANNING Screen_Shot_2022-12-11_at_19.23.04

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Enable the echo "Feature.enable(:scan_execution_tags)" | rails c
  3. Navigate to http://gdk.test:3443/groups/flightjs/-/security/policies/new?type=scan_execution_policy
  4. Verify tags for select scanners
  5. Navigate to http://gdk.test:3443/flightjs/Flight/-/security/policies/new?type=scan_execution_policy
  6. Verify tags for select scanners

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382994 (closed)

Merge request reports