Skip to content

Treat wiki as code for global_search indexing SLIs

Terri Chu requested to merge 378307-treat-wikis-as-code-for-search-sli into master

What does this MR do and why?

Related to #378307 (closed)

Wiki and Code are both indexed using the gitlab_elasticsearch_indexer through the ElasticCommitIndexerWorker. The SLI goal should be the same for both. I also moved some constants to allow for stubbing in specs (so future updates to the goals do not require specs changes).

The plan is to eventually change to using search_indexed_bytes_per_second metric in place of search_indexing_duration_s. However, that metric is not available for Code/Wiki indexing yet (only the other content). I opted to take the smaller iteration to fix the SLI goal for Wiki before working on implementing bytes/sec for them. This will allow the switch to search_indexed_bytes_per_second without impacting Code/Wiki SLIs.

Screenshots or screen recordings

N/A

How to set up and validate locally

N/A

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Terri Chu

Merge request reports