Skip to content

Update default preferred_language value of user

Baodong requested to merge gitlab-jh/jh-team/gitlab:feat/update-user-default-preferred-language into master

What does this MR do and why?

Update default preferred_language value of user from I18n.default_locale to Gitlab::CurrentSettings.default_preferred_language.

Background

The MR !102612 (merged) introduces a new attribute default_preferred_language for ApplicationSetting.

The main function of this value is to determine the rendered language of the unlogged users.

The default value for Gitlab::CurrentSettings.default_preferred_language is en.

So for Gitlab.com, the rendered language seen by users who are not logged in is English.

Details see issue: #367626 (closed)

The impact of this modification

The administrator can modify default_preferred_language to make the preferred_language of newly registered users the same as Gitlab::CurrentSettings.default_preferred_language.

This feature is very useful for users whose native language is not English.

Also, for users using English, there is no change as English is always the default.

/cc JH EM @prajnamas

/cc JH PM @lpeng1991

Merge request reports