Draft: Connect overage modal to account
What does this MR do and why?
Describe in detail what your merge request does and why.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #363498 (closed)
Merge request reports
Activity
changed milestone to %15.7
- A deleted user
added backend feature flag labels
7 Warnings 70b9bd07: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 233b5315: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 233b5315: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 233b5315: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. d770fc6a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 46ffe8ae: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michał Wielich (
@michold
) (UTC+0, 7 hours ahead of@lmeckley
)Pavel Shutsin (
@pshutsin
) (UTC+1, 8 hours ahead of@lmeckley
)frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 12.5 hours ahead of@lmeckley
)Robert Hunt (
@rob.hunt
) (UTC+0, 7 hours ahead of@lmeckley
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #363498 (closed)
added 250 commits
-
70b9bd07...e16d4f70 - 243 commits from branch
master
- eacea1ee - Add guest overage modal
- a00fa0bb - Add link to confirm modal
- 20cc0fcb - Use modalHtmlMessage for confirmAction
- 6ee79693 - Add tests for guest overage modal
- e7fcb409 - progress
- b73273fb - Trying to test confirm action
- 4b7b4be5 - Initial data hook up
Toggle commit list-
70b9bd07...e16d4f70 - 243 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e16d4f70 and 70b9bd07
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.46 MB +3.12 KB 0.1 % mainChunk 1.86 MB 1.86 MB - 0.0 % Significant Growth: 10Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.milestones.show 616.6 KB 757.28 KB +140.68 KB 22.8 % pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 % pages.groups.milestones.edit 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.groups.milestones.new 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.projects.milestones.edit 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.index 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.new 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.groups.observability.dashboards 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.explore 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.manage 105.65 KB 117.75 KB +12.1 KB 11.5 % Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.81 MB -130.61 KB -4.3 % pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 % pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 % pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for e16d4f70. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger5 5 6 6 AVATAR_SIZE = 40 7 7 8 def group_members_app_data(group, members:, invited:, access_requests:, banned:, include_relations:, search:) 8 def group_member_select_options changed this line in version 3 of the diff
- Resolved by Sharmad Nachnolkar
3 3 module EE::Groups::GroupMembersHelper 4 4 extend ::Gitlab::Utils::Override 5 5 6 override :group_member_select_options changed this line in version 3 of the diff
1 export const guestOverageConfirmAction = () => { No worries at all!! I'll get this cleaned up today; this was partially taken from my super old MR which is why the diff is all wonky right now. Once I fix that up it should be much more clear
added 214 commits
-
4b7b4be5...23d6ec87 - 207 commits from branch
master
- 24cc441f - Add guest overage modal
- b2fe7ff2 - Add link to confirm modal
- effb517e - Use modalHtmlMessage for confirmAction
- ed1715d4 - Add tests for guest overage modal
- 5a798471 - progress
- 28657d4b - Trying to test confirm action
- f13367a2 - Initial data hook up
Toggle commit list-
4b7b4be5...23d6ec87 - 207 commits from branch
mentioned in merge request !105613 (merged)
changed milestone to %15.8
added missed:15.7 label
changed milestone to %15.9
added missed:15.8 label