Skip to content
Snippets Groups Projects

Draft: Connect overage modal to account

Closed Laura Callahan requested to merge 363498-overage-modal_data into master
4 unresolved threads

What does this MR do and why?

Describe in detail what your merge request does and why.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #363498 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
5 5
6 6 AVATAR_SIZE = 40
7 7
8 def group_members_app_data(group, members:, invited:, access_requests:, banned:, include_relations:, search:)
8 def group_member_select_options
  • Sharmad Nachnolkar
  • 3 3 module EE::Groups::GroupMembersHelper
    4 4 extend ::Gitlab::Utils::Override
    5 5
    6 override :group_member_select_options
  • 1 export const guestOverageConfirmAction = () => {
    • @lmeckley Sorry for poking at this while in draft mode. I was just trying to get context of what's happening in this MR so that I can take it over smoothly next week. I dropped some comments for clarification. Could you please take a look and help me get some clarity. TIA :slight_smile:

    • Author Contributor

      No worries at all!! I'll get this cleaned up today; this was partially taken from my super old MR which is why the diff is all wonky right now. Once I fix that up it should be much more clear :sweat_smile:

    • Please register or sign in to reply
  • Laura Callahan added 214 commits

    added 214 commits

    Compare with previous version

  • Laura Callahan added 5 commits

    added 5 commits

    Compare with previous version

  • Sharmad Nachnolkar mentioned in merge request !105613 (merged)

    mentioned in merge request !105613 (merged)

  • Sharmad Nachnolkar changed target branch from master to 363498-overage-modal-v2

    changed target branch from master to 363498-overage-modal-v2

  • Sharmad Nachnolkar changed target branch from 363498-overage-modal-v2 to master

    changed target branch from 363498-overage-modal-v2 to master

  • 🤖 GitLab Bot 🤖 changed milestone to %15.8

    changed milestone to %15.8

  • 🤖 GitLab Bot 🤖 changed milestone to %15.9

    changed milestone to %15.9

  • Please register or sign in to reply
    Loading