Draft: Add filter by ref to artifacts management page
What does this MR do and why?
This MR depends on !104191 (closed)
Describe in detail what your merge request does and why.
Screenshots or screen recordings
Screen_Recording_2022-12-08_at_15.23.02
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #367294
Merge request reports
Activity
changed milestone to %15.7
assigned to @mfluharty
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Drew Cimino (
@drew
) (UTC+0, 7 hours ahead of@mfluharty
)Ethan Urie (
@eurie
) (UTC-5, 2 hours ahead of@mfluharty
)frontend Nataliia Radina (
@nradina
) (UTC+0, 7 hours ahead of@mfluharty
)Simon Knox (
@psimyn
) (UTC+11, 18 hours ahead of@mfluharty
)UX Gina Doyle (
@gdoyle
) (UTC-5, 2 hours ahead of@mfluharty
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #367294
added 1 commit
- 279960ce - Add filter by ref to artifacts management page
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c29a3e65 and 279960ce
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.46 MB +4.48 KB 0.1 % mainChunk 1.86 MB 1.86 MB - 0.0 % Significant Growth: 13Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.artifacts 1.25 MB 1.45 MB +200.35 KB 15.6 % pages.projects.artifacts.browse 1.25 MB 1.45 MB +200.35 KB 15.6 % pages.projects.artifacts.file 1.27 MB 1.46 MB +200.35 KB 15.4 % pages.dashboard.milestones.show 616.6 KB 757.28 KB +140.68 KB 22.8 % pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 % pages.groups.milestones.edit 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.groups.milestones.new 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.projects.milestones.edit 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.index 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.new 1.78 MB 1.87 MB +100.6 KB 5.5 % The table above is limited to 10 entries. Please look at the full report for more details
Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.81 MB -130.61 KB -4.3 % pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 % pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 % pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for c29a3e65. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 279960ceexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
changed milestone to %15.8
added missed:15.7 label
changed milestone to %15.9
added missed:15.8 label
changed milestone to %15.10
added missed:15.9 label
changed milestone to %15.11
added missed:15.10 label
I'm closing this MR - see my comment in the issue for more details.