Update gitlab migration and github importers dropdown to use graphql
What does this MR do and why?
As a part of Update all import-related group selection dropd... (#375958 - closed) we're unifying all our group selection dropdowns to use single source of truth - specifically GraphQL
This MR updates all project-based importers which use _githubish
partial (it's almost all of them) and also gitlab migration feature to use dropdown
Screenshots or screen recordings
GitLab Migration
GitHub
How to set up and validate locally
GitLab Migration
- Open "New group" -> Import (
/groups/new
) - Use
https://gitlab.com
as source instance andGeK1Nis4j-SY1X4sqE5c
as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here) - Open any dropdown and see available groups for user
GitHub
- Generate new GitHub token at https://github.com/settings/tokens
- open
/import/github/new
and use that token - Open any dropdown and see available groups for user
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.7
assigned to @xanf
- A deleted user
added backend label
2 Warnings This merge request is quite big (505 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tyler Amos (
@tyleramos
) (UTC-5, 7 hours behind@xanf
)Doug Stull (
@dstull
) (UTC-5, 7 hours behind@xanf
)frontend Andrei Zubov (
@andrei.zubov
) (UTC+1, 1 hour behind@xanf
)Himanshu Kapoor (
@himkp
) (UTC+1, 1 hour behind@xanf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 94d4fcea and 05914dc4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.52 MB +10.27 KB 0.3 % mainChunk 1.95 MB 1.95 MB - -0.0 % Significant Growth: 7Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.import.bitbucket.status 244.46 KB 882.83 KB +638.37 KB 261.1 % pages.import.bitbucket_server.status 246.78 KB 885.16 KB +638.37 KB 258.7 % pages.import.fogbugz.status 240.61 KB 878.99 KB +638.37 KB 265.3 % pages.import.gitea.status 240.61 KB 878.99 KB +638.37 KB 265.3 % pages.import.github.status 240.61 KB 878.99 KB +638.37 KB 265.3 % pages.import.gitlab.status 240.61 KB 878.99 KB +638.37 KB 265.3 % pages.import.manifest.status 240.61 KB 878.99 KB +638.37 KB 265.3 % Significant Reduction: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.groups.index 214.01 KB 208.87 KB -5.14 KB -2.4 % pages.explore.groups 215.84 KB 210.7 KB -5.14 KB -2.4 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 94d4fcea. So we have used data from: 05265082.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 05914dc4expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Govern | 15 | 0 | 5 | 3 | 20 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Manage | 39 | 0 | 4 | 7 | 43 | ❗ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 152 | 0 | 15 | 10 | 167 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Simon Knox
@arfedoro could you please review this one?
requested review from @arfedoro
- Resolved by Artur Fedorov
- Resolved by Illya Klymov
@arfedoro
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Simon Knox
@justin_ho could you please take over frontend maintainer review?
requested review from @justin_ho and removed review request for @arfedoro
added 59 commits
-
5a096730...5dc53460 - 58 commits from branch
master
- 05914dc4 - Update import group dropdown to use graphql
-
5a096730...5dc53460 - 58 commits from branch
requested review from @psimyn and removed review request for @justin_ho
- Resolved by Simon Knox
- Resolved by Simon Knox
@xanf this looks great – just one question
enabled an automatic merge when the pipeline for e7ec402b succeeds
mentioned in commit 77b55d3a
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)
mentioned in merge request !108654 (merged)
added groupimport and integrate label and removed 1 deleted label