Skip to content
Snippets Groups Projects

Update gitlab migration and github importers dropdown to use graphql

All threads resolved!

What does this MR do and why?

As a part of Update all import-related group selection dropd... (#375958 - closed) we're unifying all our group selection dropdowns to use single source of truth - specifically GraphQL This MR updates all project-based importers which use _githubish partial (it's almost all of them) and also gitlab migration feature to use dropdown

Screenshots or screen recordings

GitLab Migration

image

GitHub

image

How to set up and validate locally

GitLab Migration

  • Open "New group" -> Import (/groups/new)
  • Use https://gitlab.com as source instance and GeK1Nis4j-SY1X4sqE5c as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here)
  • Open any dropdown and see available groups for user

GitHub

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Illya Klymov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Illya Klymov changed milestone to %15.7

    changed milestone to %15.7

  • assigned to @xanf

  • Illya Klymov added 1 commit

    added 1 commit

    • 6a248899 - Update import group dropdown to use graphql

    Compare with previous version

  • A deleted user added backend label

    added backend label

  • 2 Warnings
    :warning: This merge request is quite big (505 lines changed), please consider splitting it into multiple merge requests.
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Tyler Amos current availability (@tyleramos) (UTC-5, 7 hours behind @xanf) Doug Stull current availability (@dstull) (UTC-5, 7 hours behind @xanf)
    frontend Andrei Zubov current availability (@andrei.zubov) (UTC+1, 1 hour behind @xanf) Himanshu Kapoor current availability (@himkp) (UTC+1, 1 hour behind @xanf)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 94d4fcea and 05914dc4

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.51 MB 3.52 MB +10.27 KB 0.3 %
    mainChunk 1.95 MB 1.95 MB - -0.0 %

    :fearful: Significant Growth: 7

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.import.bitbucket.status 244.46 KB 882.83 KB +638.37 KB 261.1 %
    pages.import.bitbucket_server.status 246.78 KB 885.16 KB +638.37 KB 258.7 %
    pages.import.fogbugz.status 240.61 KB 878.99 KB +638.37 KB 265.3 %
    pages.import.gitea.status 240.61 KB 878.99 KB +638.37 KB 265.3 %
    pages.import.github.status 240.61 KB 878.99 KB +638.37 KB 265.3 %
    pages.import.gitlab.status 240.61 KB 878.99 KB +638.37 KB 265.3 %
    pages.import.manifest.status 240.61 KB 878.99 KB +638.37 KB 265.3 %

    :tada: Significant Reduction: 2

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.dashboard.groups.index 214.01 KB 208.87 KB -5.14 KB -2.4 %
    pages.explore.groups 215.84 KB 210.7 KB -5.14 KB -2.4 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @mikegreiling, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 94d4fcea. So we have used data from: 05265082.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Illya Klymov added 1 commit

    added 1 commit

    • 5a096730 - Update import group dropdown to use graphql

    Compare with previous version

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 05914dc4

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Govern                             | 15     | 0      | 5       | 3     | 20    | ❗     |
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Manage                             | 39     | 0      | 4       | 7     | 43    | ❗     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 152    | 0      | 15      | 10    | 167   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Illya Klymov marked this merge request as ready

    marked this merge request as ready

  • Illya Klymov changed title from Draft: Resolve "Update all import-related group selection dropdowns to use graphql" to Update gitlab migration and github importers dropdown to use graphql

    changed title from Draft: Resolve "Update all import-related group selection dropdowns to use graphql" to Update gitlab migration and github importers dropdown to use graphql

  • Illya Klymov marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Illya Klymov requested review from @arfedoro

    requested review from @arfedoro

  • Artur Fedorov approved this merge request

    approved this merge request

  • Artur Fedorov
  • :wave: @arfedoro, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Artur Fedorov requested review from @justin_ho and removed review request for @arfedoro

    requested review from @justin_ho and removed review request for @arfedoro

  • Illya Klymov added 59 commits

    added 59 commits

    Compare with previous version

  • Illya Klymov requested review from @psimyn and removed review request for @justin_ho

    requested review from @psimyn and removed review request for @justin_ho

  • Simon Knox
  • Simon Knox
  • @xanf this looks great – just one question

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox enabled an automatic merge when the pipeline for e7ec402b succeeds

    enabled an automatic merge when the pipeline for e7ec402b succeeds

  • merged

  • Simon Knox mentioned in commit 77b55d3a

    mentioned in commit 77b55d3a

  • added workflowstaging label and removed workflowcanary label

  • Illya Klymov mentioned in merge request !108654 (merged)

    mentioned in merge request !108654 (merged)

  • 🤖 GitLab Bot 🤖 added groupimport and integrate label and removed 1 deleted label

    added groupimport and integrate label and removed 1 deleted label

  • Please register or sign in to reply
    Loading