Skip to content

Allow aggregating CE events with EE events

Michał Wielich requested to merge michold-ce-ee-event-aggregation into master

What does this MR do and why?

Related to #369058 (closed)

We want to make it possible to use CE and EE events together in metrics.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

.

How to set up and validate locally

  1. Create a new CE metric definition file using AggregatedMetric instrumentation_class and event names that combine both EE and CE events [by using event names that are defined in both CE and EE folder]
  2. Open a rails console with FOSS_ONLY=1 env variable set and try creating a new service ping by running service_ping = ServicePing::BuildPayload.new.execute
  3. To check the new metric's value in service ping, use the metric's key_path value like so:
key_path = xxx # use the 'key_path' value of the new metric here
service_ping.dig(dig(*key_path.split('.')))

This should return the value appropriate for the defined events and operation [AND/OR], skipping the listed EE events.

  1. When repeating steps 2-3 in a rails console without FOSS_ONLY=1 set, the value returned in point 3 should not skip EE events.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Michał Wielich

Merge request reports