Skip to content

Do not log if database load balancing is unchanged

Simon Tomlinson requested to merge reduce-database-load-balancer-logs into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Previously, each rails worker thread would log when the database load balancer queried for new hosts and was unchanged. This produced roughly 10% of the log volume on gitlab.com.

Removing this log message still shows when the load balancer changes, so we still get observability into the process without the enormous log volume.

These log messages are currently being dropped after gitlab-com/gl-infra/k8s-workloads/gitlab-helmfiles!1169 (merged), but we would like to turn the load balancer logs back on after the log volume is reduced.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Set up local load balancing, and wait 2 minutes for logs to show up in lob/database_load_balancing.log. Note that the host_list_unchanged log disappears with this change.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports