Skip to content

Downstream pipelines link in the mini-pipeline graph opens the MR page

What does this MR do and why?

In the merge request page, the mini-graph counter (+x downstreams) for merged results leads to the merge request page. This is because the pipelinePath prop is not passed, so the link leads to the current page. To fix this, we want to pass the link into the component.

There is no need for a test here because all we are doing is passing the pipeline path as a prop and such a test feels very redundant and would not prevent someone from removing the prop and changing the spec 🤷

Screenshots or screen recordings

Before After
Screen_Recording_2022-12-07_at_3.39.48_PM Screen_Recording_2022-12-07_at_3.45.38_PM

How to set up and validate locally

  1. Create a pipeline configuration file with downstream pipelines. Here is an example:
stages:
  - build
  - prepare

job_1:
  stage: build
  script: echo hello

trigger_child:
  stage: prepare
  trigger:
    include:
      - local: sub/child.yml

trigger_child_2:
  stage: prepare
  trigger:
    include:
      - local: sub/child.yml

trigger_child_3:
  stage: prepare
  trigger:
    include:
      - local: sub/child.yml

trigger_child_4:
  stage: prepare
  trigger:
    include:
      - local: sub/child.yml

trigger_child_5:
  stage: prepare
  trigger:
    include:
      - local: sub/child.yml
  1. Now in your repository, create a file called child.yml and add the following into it:
job_from_child_pipeline:
  stage: build
  script: echo hello from a child pipeline!
  1. Make sure you have runners setup
  2. Create a Merge request
  3. Go to the merge request page
  4. In the main page, search for the pipeline widget
  5. Click on the +2 sign of the pipeline mini-graph
  6. Notice you are being taken to the pipeline page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #367505 (closed)

Edited by Frédéric Caplette

Merge request reports