Skip to content

Draft: SLI Apdex & ErrorRate method change

Hercules Merscher requested to merge gitlab-metrics-sli-labels-proposal into master

What does this MR do and why?

Given the discussion started on the previous MR !106163 (comment 1197988622), the issue gitlab-com/gl-infra/scalability#2058 was created to propose a change, and this MR is the outcome of a proposal for that.

In order to avoid misuse, a slight change has been made to for the required labels to be passed to the increment method of Apdex and ErrorRate classes, therefore making the contract explicit.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Hercules Merscher

Merge request reports