Skip to content

Rename disabled_with_override to disabled_and_overridable

What does this MR do and why?

Renaming the underlying setting to improve readability of the generated docs as a follow up to #337124 (closed). The approach is to deprecate disabled_with_override in favour of disabled_and_overridable and to remove disabled_with_override with the next milestone.

The associated deprecation issue: #385636 (closed)

Screenshots or screen recordings

Confirmed the new value was sent in the request: image

Querying the gql api shows the new value being used as well. Screenshot_2022-12-12_at_3.22.32_PM

How to set up and validate locally

Given two groups, one group and one subgroup.

Group can be changed

  1. Visit Group -> CI/CD Settings
  2. Enable/disable the toggle in the group to check how the data is stored.

Subgroup cannot be changed

  1. Enable the "Shared runners" toggle in the group
  2. Visit Subgroup -> CI/CD Settings
  3. Confirm the form is disabled in the subgroup.

Graphql Query

  1. http://gdk.test:3000/-/graphql-explorer
  2. Run the following query
{
  group(fullPath: "top-level-group") {
    fullPath
    sharedRunnersSetting
    descendantGroups {
      nodes {
        fullPath
        sharedRunnersSetting
      }
    }
  }
}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #337124 (closed)

Edited by Tymm Schmitke

Merge request reports