Skip to content

Removes incident creation from read-only abilities

Vijay Hawoldar requested to merge vij-incident-management-policy into master

What does this MR do and why?

❗ this MR is blocked by !106167 (merged) because until that's merged, Issue management will still be excluded when read-only, which inherently means incident management also is.

In https://gitlab.com/gitlab-org/gitlab/-/issues/363473 we are adjusting which features are made read-only.

This MR removes Incident creation from that list

Read-only mode is not yet in use because it relates to unreleased work described in the linked issue above

How to set up and validate locally

  1. Checkout master branch
  2. Adjust the read_only? method to return true 
      def read_only?
    true
  end
  3. Attempt to create an Incident (Project -> Monitor -> Incidents)
  4. 👆🏽 should not be possible
  5. Checkout this branch (vij-incident-management-policy)
  6. Re-attempt to perform the same action
  7. 👆🏽 should be possible

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports