Skip to content

Remove the `packages_size_counter_attribute ` feature flag

David Fernandez requested to merge 381287-remove-feature-flag into master

🚛 Context

We changed how the packages_size metric is updated in the ProjectStatistics object.

We went from

  • Incremental updates through SQL statements to
  • a CounterAttribute.

A CounterAttribute will basically buffer all the updates to a counter in Redis. Then a background job will pick these updates and persist them in the database.

This allows:

  • avoiding concurrent updates.
  • avoiding a large amount of UPDATE SQL statements on a busy table.

More information in !102978 (merged).

This change is gated behind a feature flag. Rollout issue: #381287 (closed).

The feature flag has been enabled for more than a week. The expected impact has been observed: no more concurrent updates.

🔬 What does this MR do and why?

  • Remove the packages_size_counter_attribute feature flag and the related specs.

📺 Screenshots or screen recordings

None

⚙ How to set up and validate locally

See !102978 (merged)

🚦 MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Fernandez

Merge request reports