Draft: Test N+1 fix
What does this MR do and why?
Describe in detail what your merge request does and why.
This is a temporary MR to test possible fixes to the N+1 issue being seen in a community contribution.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @pedropombeiro
- A deleted user
added frontend label
9 Warnings bb614b13: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a0e9ed2f: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 9de6860e: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 01935112: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. cd1f170c: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. cd1f170c: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alex Buijs (
@alexbuijs
) (UTC+1, same timezone as@pedropombeiro
)Doug Stull (
@dstull
) (UTC-5, 6 hours behind@pedropombeiro
)frontend Miranda Fluharty (
@mfluharty
) (UTC-7, 8 hours behind@pedropombeiro
)Justin Ho (
@justin_ho
) (UTC+7, 6 hours ahead of@pedropombeiro
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @pedropombeiro - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 08f42a51 and a0e9ed2f
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 1.86 MB 1.94 MB +83.6 KB 4.4 % average 3.45 MB 3.5 MB +41.41 KB 1.2 % Significant Growth: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.milestones.show 616.6 KB 682.65 KB +66.06 KB 10.7 % pages.projects.branches.index 1.03 MB 1.07 MB +35.08 KB 3.3 % pages.groups.observability.dashboards 105.65 KB 117.19 KB +11.53 KB 10.9 % pages.groups.observability.explore 105.65 KB 117.19 KB +11.53 KB 10.9 % pages.groups.observability.manage 105.65 KB 117.19 KB +11.53 KB 10.9 % New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.web_ide.remote_ide 0 Bytes 6.62 KB +6.62 KB 100.0 % Significant Reduction: 187Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.73 MB -205.37 KB -6.8 % pages.projects.licenses.index 2.24 MB 2.05 MB -198.48 KB -8.6 % pages.projects.settings.merge_requests 2.19 MB 2.06 MB -126.73 KB -5.7 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.26 MB -125.95 KB -8.9 % pages.projects.settings.repository.show 1.39 MB 1.26 MB -125.95 KB -8.9 % pages.projects.shared.web_ide_link 991.92 KB 910.67 KB -81.25 KB -8.2 % pages.groups.registry.repositories 1.26 MB 1.19 MB -75.56 KB -5.9 % pages.projects.registry.repositories 1.43 MB 1.36 MB -75.56 KB -5.2 % jira_connect_app 371.83 KB 297.21 KB -74.63 KB -20.1 % pages.admin.applications 91.02 KB 16.4 KB -74.63 KB -82.0 % The table above is limited to 10 entries. Please look at the full report for more details
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 08f42a51. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for a0e9ed2fexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 130 commits
-
a7421978...89cbf13f - 127 commits from branch
master
- 4780ef72 - Base commit
- 21f1d969 - Fix unrelated test
- 1903dace - Try to fix n+1 issue
Toggle commit list-
a7421978...89cbf13f - 127 commits from branch
added 24 commits
-
1903dace...be02f3d9 - 22 commits from branch
master
- eda46c3a - Base commit
- 1ccb6a84 - Try to fix n+1 issue
-
1903dace...be02f3d9 - 22 commits from branch
added 25 commits
-
1ccb6a84...eda01e01 - 23 commits from branch
master
- 98778960 - Base commit
- 4ce9e370 - Try to fix n+1 issue
-
1ccb6a84...eda01e01 - 23 commits from branch
added 95 commits
-
4ce9e370...46e3423a - 92 commits from branch
master
- fb1ec57f - Base commit
- 14330708 - Try to fix n+1 issue
- 51e2bfa9 - Use pipeline_status
Toggle commit list-
4ce9e370...46e3423a - 92 commits from branch
added 328 commits
-
51e2bfa9...25ae8281 - 324 commits from branch
master
- 902e722d - Base commit
- 1483ff05 - Try to fix n+1 issue
- c24ec26a - Use pipeline_status
- a1224cc4 - Apply suggestion
Toggle commit list-
51e2bfa9...25ae8281 - 324 commits from branch
removed frontend label
added 1 commit
- 13d7423d - Preload project's associations as soon as we know it's a Project
- A deleted user
added frontend label
added 1 commit
- 5042bfe8 - Move the preload into GroupChildEntity constructor
added 491 commits
-
e510c49f...7135f3ca - 479 commits from branch
master
- cd1f170c - Base commit
- bb614b13 - Try to fix n+1 issue
- 01935112 - Use pipeline_status
- 9de6860e - Apply suggestion
- 6e33aa58 - Preload project's associations as soon as we know it's a Project
- aaf942e9 - Move the preload into GroupChildEntity constructor
- 2567cb7b - Move the eager load to serializer
- 26b67de1 - Missing a question mark
- b137162e - Make sure children is array
- 3c0c1540 - Add debug information for query recorder
- b5473923 - Move eager load to controller
- 8b9fd3d8 - Fix Rubocop issues
Toggle commit list-
e510c49f...7135f3ca - 479 commits from branch