Add a Search Within token to issues list search
What does this MR do and why?
Implements search in issue titles only (#25046 - closed)
A follow-up of Draft: Add Title filter to Issues search (!86999 - closed) and Draft: Add title and description filter to issu... (!105749 - closed)
This change adds a new Search Within
token to the issues list search. With two options supported: Titles
and Descriptions
.
This would allow to search only by titles or descriptions in the issues list.
Screenshots or screen recordings
Screen_Recording_2022-12-05_at_15.13.16
Token list dropdown
Available options
How to set up and validate locally
- Open project issues list
- Enter search query
- Select a
Search Within
token - Select either a
Titles
orDescriptions
option - Hit
Enter
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.7
added devopsplan featureaddition frontend issue list labels
assigned to @slashmanov
added typefeature label
added sectiondev label
added UX label
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
mentioned in merge request !105749 (closed)
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.94b653aa: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Doug Stull (
@dstull
) (UTC-5, 9 hours behind@slashmanov
)Miguel Rincon (
@mrincon
) (UTC+1, 3 hours behind@slashmanov
)UX Matthew Nearents (
@mnearents
) (UTC-8, 12 hours behind@slashmanov
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Andrew Fontaine
@mnearents hi! Could you please review the UX of this MR when you have time?
Please consider this context as well.
requested review from @mnearents
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8fc50809 and fa03c83d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - 0.0 % mainChunk 1.86 MB 1.86 MB - 0.0 %
Note: We do not have exact data for 8fc50809. So we have used data from: be207014.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for fa03c83dexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 18 commits
-
8240bda4...ea8d13d3 - 16 commits from branch
master
- 794cce41 - Add a Search Within token to issues list search
- 26862b55 - Add messages to locale
-
8240bda4...ea8d13d3 - 16 commits from branch
Setting label groupcode review based on
@slashmanov
's group.added groupcode review label
@mnearents
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @mnearents
added devopscreate label and removed devopsplan label
requested review from @dstull
added 226 commits
-
26862b55...d55629d1 - 224 commits from branch
master
- 94b653aa - Add a Search Within token to issues list search
- fa03c83d - Add messages to locale
-
26862b55...d55629d1 - 224 commits from branch
requested review from @afontaine and removed review request for @dstull
This looks great! thanks @slashmanov
enabled an automatic merge when the pipeline for c43f3ee9 succeeds
mentioned in commit 40b4d8ce
mentioned in issue #25046 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in merge request gitlab-com/www-gitlab-com!116014 (merged)
mentioned in issue #386112
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)
mentioned in issue #19587
mentioned in epic &12574