Migrates buttons to Pajamas
What does this MR do and why?
Migrates buttons on various dashboard pages to Pajamas components
Closes #384401 (closed), #384415 (closed), #384413 (closed)
Screenshots or screen recordings
Issue | Location | Before | After |
---|---|---|---|
Snippets #384401 (closed) | http://gdk.test:3000/dashboard/snippets | ![]() |
![]() |
Projects #384415 (closed) | http://gdk.test:3000/dashboard/projects | ![]() |
![]() |
Activity #384413 (closed) | http://gdk.test:3000/dashboard/activity | ![]() |
![]() |
How to set up and validate locally
Snippets
- Navigate to http://gdk.test:3000/dashboard/snippets, migrated button is New snippet button at the top (must have >0 snippets to see this)
Projects
- Navigate to http://gdk.test:3000/dashboard/projects, migrated button is New project button at the top
Activity
- Navigate to http://gdk.test:3000/dashboard/activity, migrated button is the Subscribe RSS button near the header
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @nickleonard
added devopsfoundations sectiondev labels
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serena Fang (
@serenafang
) (UTC-6, same timezone as@nickleonard
)Terri Chu (
@terrichu
) (UTC-5, 1 hour ahead of@nickleonard
)frontend Artur Fedorov (
@arfedoro
) (UTC+1, 7 hours ahead of@nickleonard
)Phil Hughes (
@iamphill
) (UTC+0, 6 hours ahead of@nickleonard
)UX Matej Latin (
@matejlatin
) (UTC+1, 7 hours ahead of@nickleonard
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded maintenancerefactor typemaintenance labels
changed milestone to %15.7
- Resolved by Coung Ngo
@mnearents @arfedoro Could you please review these Pajamas migrations? They're a bit spread out but hopefully I've made it easy enough to find each
requested review from @mnearents and @arfedoro
added FY23Q4 label
@arfedoro
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
- Resolved by Coung Ngo
@nickleonard I just wanted to be sure I was looking at the correct page. The snippets page is the page within a project correct?
- The snippets button looked good.
- The new project button looked good.
- The RSS button was getting cut off on click. If this isn't due to the pajamas migration though let me know and I'll approve:
- Resolved by Nick Leonard
mentioned in issue #384964 (closed)
removed review request for @mnearents
enabled an automatic merge when the pipeline for f72670aa succeeds
mentioned in commit 7337b4f9
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label