Correct avatar spacing in project activity
What does this MR do and why?
Ensures the spacing around the activity avatar matches spacing across the app.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
The after matches the spacing found on the user profile page:
How to set up and validate locally
- Navigate to a project
- Navigate to
Project Information > Activity
- Review activity entry across tabs
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @tauriedavis
added FY23Q4 Pajamas Migration Day labels
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 13.5 hours ahead of@tauriedavis
)Coung Ngo (
@cngo
) (UTC+0, 8 hours ahead of@tauriedavis
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@tauriedavis - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c2357cf6 and 78738b04
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - 0.0 % mainChunk 1.86 MB 1.86 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 % Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.8 MB -132.91 KB -4.4 % pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 % pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 % pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for c2357cf6. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 78738b04expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Taurie Davis
@pburdette would you mind reviewing here?
assigned to @pburdette
requested review from @pburdette
unassigned @pburdette
@pburdette
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @cngo
removed review request for @pburdette
changed milestone to %15.7
enabled an automatic merge when the pipeline for 00d8c88b succeeds
mentioned in commit 7082d3d3
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label