Skip to content

Converting Buttons to use Pajamas components

Ross Byrne requested to merge rb-converting-pajamas-buttons-02-12-22 into master

What does this MR do and why?

This MR converts buttons to Pajamas components. I'm adding multiple issues to this MR due to the small code changes.

This MR makes changes for issues: #384438 (closed) and #384416 (closed)

Screenshots or screen recordings

Changes on page /app/views/profiles/accounts/show.html.haml for issue: #384438 (closed)

Before After
profile-enable-2fa-btn-before profile-enable-2fa-btn-after
profile-manage-2fa-btn-before profile-manage-2fa-btn-after

Changes on page /app/views/admin/users/_form.html.haml for issue: #384416 (closed)

Before After
admin-users-add-cancel-btn-before admin-users-add-cancel-btn-after
admin-users-edit-cancel-btn-before admin-users-edit-cancel-btn-after

How to set up and validate locally

For issue: #384438 (closed)

URL: http://127.0.0.1:3000/-/profile/account
File: /app/views/profiles/accounts/show.html.haml

For issue: #384416 (closed)

URL: http://127.0.0.1:3000/admin/users
File: /app/views/admin/users/_form.html.haml

When on users page, add a new user and edit an existing to check both cancel buttons.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Ross Byrne

Merge request reports