Remove Group CI minutes usage old app
What does this MR do and why?
Issue: #360784 (closed)
This is part of a list of MRs that clean up the old code for the Pipelines Tab in the Usage Quotas page. This removes the old frontend files for Group Usage Quotas.
PoC !104710 (closed)
Title | MR | Description |
---|---|---|
Remove usage_quotas_pipelines_vue feature flag | !105487 (merged) | With this MR all the old JS/ruby code will never be executed because it's never being included. This gives us more piece to break down the JS removals in more MRs. We can remove the FF as well, at this point |
Remove remaining old ruby code for usage quotas - pipelines | !105723 (merged) | This finishes the removal of all dead code on the backend |
Remove Group CI minutes usage old app | !105795 (merged) |
![]() |
Remove Profile CI minutes usage old app | !105880 (merged) | Removes the old frontend files for Profile Usage Quotas. This finishes the removal of all dead code on the frontend |
Screenshots or screen recordings
No UI changes. Details: #360785 (comment 1180904501)
How to set up and validate locally
- Checkout the branch
- Visit: http://gdk.test:3000/groups/flightjs/-/usage_quotas#pipelines-quota-tab
- Visit: http://gdk.test:3000/-/profile/usage_quotas#pipelines-quota-tab
- Make sure both pages are rendering correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @sheldonled
- A deleted user
added frontend maintenanceremoval typefeature labels
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Himanshu Kapoor (
@himkp
) (UTC+1, 1 hour ahead of@sheldonled
)Robert Hunt (
@rob.hunt
) (UTC+0, same timezone as@sheldonled
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for e06c27e7expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
mentioned in merge request !104710 (closed)
mentioned in issue #360784 (closed)
mentioned in merge request !105487 (merged)
mentioned in merge request !105723 (merged)
changed milestone to %15.7
mentioned in merge request !105880 (merged)
Setting label grouputilization based on
@sheldonled
's group.added grouputilization label
Setting label(s) devopsfulfillment sectionfulfillment based on grouputilization.
added devopsfulfillment sectionfulfillment labels
added 290 commits
-
8d84a695...c19cf408 - 289 commits from branch
led/360784-remove-usage_quotas_pipelines_vue
- 35b13808 - Remove Group CI minutes usage old app
-
8d84a695...c19cf408 - 289 commits from branch
added 640 commits
-
35b13808...2c23ef99 - 639 commits from branch
master
- 50a4a668 - Remove Group CI minutes usage old app
-
35b13808...2c23ef99 - 639 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 132fdd31 and e06c27e7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.46 MB +3.2 KB 0.1 % mainChunk 1.86 MB 1.86 MB - 0.0 % Significant Growth: 10Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.dashboard.milestones.show 616.6 KB 757.28 KB +140.68 KB 22.8 % pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 % pages.groups.milestones.edit 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.groups.milestones.new 1.67 MB 1.77 MB +100.6 KB 5.9 % pages.projects.milestones.edit 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.index 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.projects.milestones.new 1.78 MB 1.87 MB +100.6 KB 5.5 % pages.groups.observability.dashboards 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.explore 105.65 KB 117.75 KB +12.1 KB 11.5 % pages.groups.observability.manage 105.65 KB 117.75 KB +12.1 KB 11.5 % Significant Reduction: 5Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.8 MB -132.91 KB -4.4 % pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 % pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 % pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 132fdd31. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request !105849 (merged)
The failure in this pipeline is due to a flaky test. Discussion here !105849 (comment 1199889920)
- Resolved by Jose Ivan Vargas
@pburdette this is the second-to-last MR I'll ask you to review (for now
)Do you have the capacity to review this one?
requested review from @pburdette
requested review from @jivanvl and removed review request for @pburdette
enabled an automatic merge when the pipeline for a486a43d succeeds
- Resolved by Jose Ivan Vargas
Looks good to me!
added 263 commits
-
50a4a668...613dbd78 - 261 commits from branch
master
- 8e328d5f - Remove Group CI minutes usage old app
- 29dfbbef - Quarantine boards_spec due to flaky tests
-
50a4a668...613dbd78 - 261 commits from branch
mentioned in merge request !106360 (merged)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 31 commits
-
29dfbbef...30a08d85 - 30 commits from branch
master
- e06c27e7 - Remove Group CI minutes usage old app
-
29dfbbef...30a08d85 - 30 commits from branch
@digitalmoksha
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 87f8a739 succeeds
mentioned in commit 80260743
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)