Skip to content

Use Pajamas button component for form submit

Daphne Kua requested to merge dkua1-pajamas into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Migrates some buttons as part of Pajamas Migration Day.

Epic: &8537 (closed)

Closes: #374855 (closed), #374814 (closed), #374767 (closed), #374853 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Resend email confirmation

Issue: #374767 (closed)

Slight alignment with text below button.

Before After
app_views_devise_confirmations_new.html.haml_-_before app_views_devise_confirmations_new.html.haml_-after__alignment

Change your password (from 'Reset password instructions' email)

Issue: #374814 (closed)

Slight alignment with text below button.

Before After
app_views_devise_passwords_edit.html.haml_-_before app_views_devise_passwords_edit.html.haml_-after__alignment

Reset password (from 'Forgot your password')

Issue: #374853 (closed)

Slight alignment with text below button.

Before After
app_views_devise_passwords_new.html.haml_-_before app_views_devise_passwords_new.html.haml_-after__alignment

Welcome to GitLab page

Issue: #374855 (closed)

Slight alignment. This was proposed by @markrian in !105790 (comment 1242724481):

I added some gl-mb-0 classes to avoid the extra margin, particularly on the welcome page:

Before After
ee_app_views_registrations_welcome__button.html.haml_-_before ee_app_views_registrations_welcome__button.html.haml_-_after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Resend email confirmation

Change your password (from 'Reset password instructions' email)

  • Set up SMTP to receive email notifications
  • In sign in page, click 'Forgot your password'
  • Enter a valid username email (Sign up if needed)
  • Retrieve 'Reset password instructions' email and click on it

Reset password (from 'Forgot your password')

Welcome to GitLab page

See section above on ▶ Note.

  • Set up SMTP to receive email notifications
  • Sign in as admin, go to Admin > Settings > General > under Sign-up restrictions, enable 'Send confirmation email on sign-up'
  • Log out and sign up as a new user
  • Retrieve 'Confirmation instructions' email and click on it

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Daphne Kua

Merge request reports