Skip to content

Remove feature_flags/form.scss and .rollout-percentage classes

What does this MR do and why?

Styles introduced in 4e6cc417 to override user agent styles for <input type="number"> also impacting usability affordances of input.

  • Remove user agent style overrides for <input type="number">
  • Remove feature_flags/form.scss
  • Remove .rollout-percentage class usage
  • Update width of feature flag percentage selection to gl-w-11
  • Update gl-text-right on percentage selection input

Screenshots or screen recordings

Description Before After After (focus)
Percent rollout feature-flag-1-before feature-flag-1-after feature-flag-1-after-focus
Percent of users feature-flag-2-before feature-flag-2-after feature-flag-2-after-focus

How to set up and validate locally

  1. Go to project feature flags e.g. /flightjs/Flight/-/feature_flags/new
  2. Select "Percent rollout" or "Percent of users"
  3. Check percentage number input

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #366609 (closed)

Merge request reports