Add comment form to work items

What does this MR do and why?

Add comment form to work item notes

Todo:

• pass register_path and signin path with provide/inject (or as props but it's lots of components to pass through)
• empty state for logged in but can't edit. currently an empty div, maybe that is ok for now

Screenshots or screen recordings

How to set up and validate locally

1. Enable work_items_mvc_2, work_items_mvc feature flags
2. Add a task to an issue
3. Add a comment to the task
4. Verify added (needs graphql explorer)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #378955 (closed)

changed milestone to %15.7

added Deliverable GitLab Free [deprecated] Accepting merge requests backend devopsplan direction documentation frontend groupproject management missed-deliverable missed:15.6 quad-planningcomplete-no-action sectiondev typefeature workflowready for development labels

assigned to @psimyn

mentioned in merge request !104825 (merged)

added 264 commits

• 6d1ba565...dc694930 - 248 commits from branch master
• 28344ef1 - Work Item widget notes
• 4adeb9bc - Get work item notes by iid
• f3ac4be4 - Filter discussions on only activity
• 4586dede - Merge branch '378949-wi-widget-notes' of gitlab.com:gitlab-org/gitlab into...
• ed894a51 - Pagination logic basic
• 809c4fc4 - UX feedback
• 225dcb3a - Work Item widget notes
• e28998dd - Get work item notes by iid
• ef4f0f07 - Filter discussions on only activity
• 5292c9c6 - Pagination logic basic
• 8471d580 - UX feedback
• e96020fe - Merge branch '378949-wi-widget-notes' of gitlab.com:gitlab-org/gitlab into...
• 57061aea - UX feedback 2
• 061fae16 - Added loader when the notes are loading
• 7e5c8ec7 - Merge branch '378949-wi-widget-notes' of gitlab.com:gitlab-org/gitlab into...
• 7b20ec8c - Add text input field for comments

Compare with previous version

	3 Warnings
	This merge request is quite big (670 lines changed), please consider splitting it into multiple merge requests.
	41081dfe: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	Please add a merge request subtype to this merge request.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Tarun Vellishetty (@tvellishetty) (UTC+5.5, 5.5 hours behind @psimyn)	Charlie Ablett (@cablett) (UTC+13, 2 hours ahead of @psimyn)
frontend	Laura Meckley (@lmeckley) (UTC-7, 18 hours behind @psimyn)	Jacques Erasmus (@jerasmus) (UTC+1, 10 hours behind @psimyn)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 2aecc6f5 and 7042bb64

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.54 MB	3.54 MB	-	0.0 %
mainChunk	1.95 MB	1.95 MB	-	0.0 %

---

Note: We do not have exact data for 2aecc6f5. So we have used data from: aa013809.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

Allure report

allure-report-publisher generated test report!

e2e-review-qa: test report for 7042bb64

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Verify           | 12     | 0      | 1       | 0     | 13    | ✅     |
| Create           | 28     | 0      | 1       | 0     | 29    | ✅     |
| Framework sanity | 9      | 0      | 1       | 0     | 10    | ✅     |
| Manage           | 34     | 0      | 3       | 1     | 37    | ❗     |
| Plan             | 49     | 0      | 1       | 0     | 50    | ✅     |
| Govern           | 24     | 0      | 5       | 0     | 29    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 156    | 0      | 13      | 1     | 169   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

changed target branch from master to 378949-wi-widget-notes

added 581 commits

• 7b20ec8c...8b4102ec - 580 commits from branch 378949-wi-widget-notes
• 6d8b178d - Merge branch '378949-wi-widget-notes' of gitlab.com:gitlab-org/gitlab into...

Compare with previous version

added 1316 commits

• 6d8b178d...a4404edc - 1314 commits from branch 378949-wi-widget-notes
• 505979d5 - Merge branch '378949-wi-widget-notes' of gitlab.com:gitlab-org/gitlab into...
• 1689b00d - Fix lint

Compare with previous version

deleted the 378949-wi-widget-notes branch. This merge request now targets the master branch

added 238 commits

• 1689b00d...ee6007b2 - 235 commits from branch master
• 4dab6a0f - fix some conflicts
• ae297e7e - Merge branch 'master' of gitlab.com:gitlab-org/gitlab into 378955-work-items-discussions-widget
• 8bf84319 - Connect a more correct mutation

Compare with previous version

added 1 commit

• 90765f0a - Connect a more correct mutation

Compare with previous version

added 51 commits

• 90765f0a...4d48d4b9 - 50 commits from branch master
• 6b3ffa45 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab into 378955-work-items-discussions-widget

Compare with previous version

added 265 commits

• 6b3ffa45...8ecd5ad4 - 264 commits from branch master
• 04f95c51 - Add comment form to work item notes

Compare with previous version

changed the description

mentioned in issue #383597 (closed)

changed milestone to %15.8

added missed:15.7 label

changed the description

added 800 commits

• 04f95c51...a5fae5a4 - 798 commits from branch master
• 29754335 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab into 378955-work-items-discussions-widget
• 0229812f - Add signed out state placeholder

Compare with previous version

added 1 commit

• e640a974 - Remove more description copypaste

Compare with previous version

changed title from Display comments on work items to Add comment form to work items

changed the description

added 1 commit

• 23cb6c89 - Add some tests and mock data

Compare with previous version

added 1 commit

• 7608cba0 - Add signin/register paths to helper

Compare with previous version

changed the description

@donaldcook this has one main todo left for the register/login paths

added 591 commits

• 7608cba0...8c50c474 - 585 commits from branch master
• ba55ba30 - Add comment form to work item notes
• 3e2e9d91 - Add signed out state placeholder
• 0078f0f3 - Remove more description copypaste
• ce1f786a - Add some tests and mock data
• ae4d5fa6 - Add signin/register paths to helper
• aad83ba1 - Add sign in and register link for comment form

Compare with previous version

assigned to @deepika.guliani

marked the checklist item pass register_path and signin path with provide/inject (or as props but it's lots of components to pass through) as completed

added 1 commit

• fcf755b5 - Add sign in and register link for comment form

Compare with previous version

added 8 commits

• 04f95c51 - Add comment form to work item notes
• 29754335 - Merge branch 'master' of gitlab.com:gitlab-org/gitlab into 378955-work-items-discussions-widget
• 0229812f - Add signed out state placeholder
• e640a974 - Remove more description copypaste
• 23cb6c89 - Add some tests and mock data
• 7608cba0 - Add signin/register paths to helper
• 9480d0b4 - Merge branch '378955-work-items-discussions-widget' of...
• c8b3e9e4 - Fix jest specs

Compare with previous version

added 96 commits

• c8b3e9e4...d8e30275 - 90 commits from branch master
• 9e657f89 - Add comment form to work item notes
• db148462 - Add signed out state placeholder
• 7542e910 - Remove more description copypaste
• 1d140cdc - Add some tests and mock data
• 68243bfc - Add signin/register paths to helper
• 24f42c5d - Add sign in and register link for comment form

Compare with previous version

marked the checklist item empty state for logged in but can't edit. currently an empty div, maybe that is ok for now as completed

@cngo Hey Can you please review this MR ? Thank you so much

requested review from @cngo

added 1 commit

• 1ddc6a96 - Remove a bunch of unused fields and methods

Compare with previous version

added 1 commit

• 967e99c7 - Fix register and sign in path injection

Compare with previous version

thankyou for excellent review @cngo!

@deepika.guliani I have replied/updated all the comments. If you can keep an eye on tests that'd be great – I have possibly broken some things

added 1 commit

• f7202f9d - Also cancel button

Compare with previous version

added 1 commit

• f9a24fa9 - Pipeline error fixed

Compare with previous version

approved this merge request

requested review from @ntepluhina and removed review request for @cngo

@cngo, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

added pipeline:mr-approved label

Nice work on the MR @psimyn @deepika.guliani and huge thanks to @cngo for the amazingly detailed review! I've added a few more minor comments, back to you

removed review request for @ntepluhina

added 1 commit

• 90d7027b - Move non reactive dependencies to options

Compare with previous version

added 1 commit

• 1cb65fec - Move non reactive dependencies to options

Compare with previous version

added 1 commit

• 640f2dc4 - Move non reactive dependencies to options

Compare with previous version

requested review from @ntepluhina

resolved all threads

approved this merge request

@deepika.guliani sorry to ping you again but there are MR conflicts We need to resolve them before merging

added 470 commits

• 640f2dc4...5862c54b - 456 commits from branch master
• 4177a3c2 - Add comment form to work item notes
• 0f3dc714 - Add signed out state placeholder
• 4b9cda5a - Remove more description copypaste
• b6a3b285 - Add some tests and mock data
• f081cc8b - Add signin/register paths to helper
• 41081dfe - Add sign in and register link for comment form
• e5d2051a - Remove a bunch of unused fields and methods
• c0119f0b - Fix register and sign in path injection
• 0f2c0c38 - Also cancel button
• 6475d047 - Pipeline error fixed
• f8da1bff - Move non reactive dependencies to options
• d4dfab3c - Test case failure
• d9f16e2d - Conflicts when rebase with master
• 7042bb64 - Conflicts when rebase with master

Compare with previous version

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 6566eacf succeeds

merged

mentioned in commit 428cf4bf

added workflowstaging-canary label and removed workflowready for development label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

mentioned in issue #387663 (closed)

mentioned in merge request !108581 (merged)

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label