Remove switch to new IDE right pane
What does this MR do and why?
It removes the right panel that invites the user to try the new Web IDE. We are replacing this panel with a callout that will appear in the button that allows opening the IDE from a project overview page as described in: #370139 (closed)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable the
vscode_web_ide
feature flag. - Go to the User Preferences page and check the "Use legacy web IDE" checkbox
- Open the Web IDE.
- You should not see the panel that invites to try the new Web IDE.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #370139 (closed)
Merge request reports
Activity
changed milestone to %15.7
assigned to @ealcantara
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 9.5 hours ahead of@ealcantara
)Jannik Lehmann (
@jannik_lehmann
) (UTC+1, 5 hours ahead of@ealcantara
)test for spec/features/*
Jay McCure (
@jay_mccure
) (UTC+10, 14 hours ahead of@ealcantara
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@himkp: Could you review this MR, please?
requested review from @himkp
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a8bcb397 and e3f654d3
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - -0.0 % mainChunk 1.86 MB 1.86 MB - 0.0 %
Note: We do not have exact data for a8bcb397. So we have used data from: 1976b6ab.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for e3f654d3expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Manage | 39 | 0 | 4 | 2 | 43 | ❗ | | Govern | 13 | 0 | 5 | 1 | 18 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 150 | 0 | 15 | 3 | 165 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 443 commits
-
257fdb49...10bc46c7 - 442 commits from branch
master
- e3f2bf01 - Remove switch to new IDE right pane
-
257fdb49...10bc46c7 - 442 commits from branch
added 120 commits
-
e3f2bf01...2c72c13e - 119 commits from branch
master
- e3f654d3 - Remove switch to new IDE right pane
-
e3f2bf01...2c72c13e - 119 commits from branch
@himkp
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
@ealcantara LGTM!
- Resolved by Peter Hegman
@peterhegman: Could you review this MR, please?
requested review from @peterhegman
enabled an automatic merge when the pipeline for 006563c8 succeeds
mentioned in commit 5fea3c4b
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !162487 (merged)