Skip to content

Remove "hash form" support in alert management router

Laurent Deketelaere requested to merge ali_o_kan/gitlab:381282-remove-hash_form-support-in-alert_management-router into master

What does this MR do and why?

Related to #381282 (closed)

Problem

Since #374724 (closed) (closed) we use the 🆕 "slash form" /root/test-proj/-/alert_management/2/details/overview for tabs in alert details.

We also support the old "hash form" /root/test-proj/-/alert_management/2/details#/overview so it redirects to the "slash form". See #374724 (closed) (comment 1143851220)

Long-term we want to only use "slash form" and remove "hash form".

Proposed solution

Remove support for "hash form".

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. In a project, create HTTP alerts from the menu Settings > Monitor > Alerts > Current integrations (Tab) > HTTP row > Settings (Actions Icon) > Send test alert (Tab) > Send (Button)

  1. Go to the menu Monitor > Alerts and click on the new created alert.
  2. Navigate between the tabs Alert details, Metrics and Activity feed and check the URL changes.
  3. Use the forward/back buttons of the browser.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #381282 (closed)

Edited by Peter Leitzen

Merge request reports