Resolve "Spec failure in `spec/features/broadcast_messages_spec.rb` | Broadcast Messages dismissable banner type behaves like a dismissable Broadcast Messages broadcast message is still hidden after refresh"
requested to merge 347118-spec-failure-in-spec-features-broadcast_messages_spec-rb-broadcast-messages-dismissable into master
What does this MR do and why?
Fixes the flaky part of the a dismissable Broadcast Messages shared examples by waiting for cookie to be set.
There was a race between complete setting cookie and page refresh, if page refresh happens first, the spec fails.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #347118 (closed)
Edited by Roy Liu