Removed the default eol editor option
What does this MR do and why?
Removes the hardcoded endOfLine
option from the default options we use for setting up Monaco editor (the one under the hood of Source Editor).
With that option Web IDE always converts the eol to LF
before committing files. Even if the files are CRLF
for a reason (project policy, etc.). This is the first step in addressing Web editors and commit API convert CRLF line en... (#21431 - closed) with the second step being updating Gitaly to not do the same conversion on the server.
Before this MR, the transformation on the client happened when switching to the "Commit" tab of Web IDE.
Screenshots or screen recordings
The problem can be observed when switching from "Edit" to "Commit" tabs of Web IDE.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Create a simple textual file with
CRLF
line endings in an editor of your choice. For example, in VSCode:
- Save the file
- In your local gdk instance, go to Web IDE of any project. For example
/-/ide/project/flightjs/Flight/edit/master/-/
- Upload a file you have just created
- Note the correct
CRLF
indicator at the bottom right
- Go to "Commit" tab of the interface. Note that the eol is still indicated correctly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #21431 (closed)