Skip to content
Snippets Groups Projects

Add a cube analytics table visualization to product analytics

Merged Jiaan Louw requested to merge 382910-add-cube-table-visualization into master

What does this MR do and why?

This MR adds a cube analytics table visualization to be used by the Product Analytics dashboards as described in #382910 (closed).

Note: This change is hidden behind a default off feature flag. See the setup instructions for more details.

Screenshots or screen recordings

image

How to set up and validate locally

  1. You need to setup the product analytics devkit if you haven't already done so. https://gitlab.com/gitlab-org/analytics-section/product-analytics/devkit
  2. Enable the feature flag: echo "Feature.enable(:product_analytics_internal_preview)" | rails c.
  3. Visit the dashboard page of any project and validate that it renders: http://localhost:3000/gitlab-org/gitlab-shell/-/product_analytics/dashboards/

This will show an empty dashboard if you have no events in clickhouse. To generate events:

  1. You can use a browser extension like tapermonkey + this userscript to generate events.
    • Using the userscript above you need to change the host to your devkit's Jitsu URL and use your Jitsu's client key.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #382910 (closed)

Edited by Jiaan Louw

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jiaan Louw changed milestone to %15.7

    changed milestone to %15.7

  • assigned to @jiaan

  • Jiaan Louw added 1 commit

    added 1 commit

    • bca7fc3d - Add a cube analytics table visualization

    Compare with previous version

  • A deleted user added frontend label

    added frontend label

  • 3 Warnings
    :warning: e500393c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: This merge request adds a new rule to app/assets/stylesheets/framework/common.scss or app/assets/stylesheets/utilities.scss.
    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Diana Zubova current availability (@dzubova) (UTC+1, same timezone as @jiaan) Simon Knox current availability (@psimyn) (UTC+11, 10 hours ahead of @jiaan)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Changes to utility SCSS files

    Addition to app/assets/stylesheets/utilities.scss

    You have added a new rule to app/assets/stylesheets/utilities.scss. Are you sure you need this rule?

    If it is a component class shared across items, could it be added to the component as a utility class or to the component's stylesheet? If not, consider adding it to app/assets/stylesheets/framework/common.scss

    If it is a new utility class, is there another class that shares the same values in either this file or in app/assets/stylesheets/utilities.scss? If not, please be sure this addition follows the Gitlab UI naming style so it may be removed when these rules are included. See Include gitlab-ui utility-class library for more about this project.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 44dcadb7 and 0229380e

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.45 MB 3.46 MB - 0.0 %
    mainChunk 1.86 MB 1.86 MB - 0.0 %

    :fearful: Significant Growth: 4

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.branches.index 1.03 MB 1.14 MB +109.7 KB 10.4 %
    pages.groups.observability.dashboards 105.65 KB 117.75 KB +12.1 KB 11.5 %
    pages.groups.observability.explore 105.65 KB 117.75 KB +12.1 KB 11.5 %
    pages.groups.observability.manage 105.65 KB 117.75 KB +12.1 KB 11.5 %

    :tada: Significant Reduction: 5

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.settings.ci_cd.show 2.93 MB 2.8 MB -132.91 KB -4.4 %
    pages.projects.licenses.index 2.24 MB 2.12 MB -123.73 KB -5.4 %
    pages.projects.settings.merge_requests 2.19 MB 2.14 MB -52.11 KB -2.3 %
    pages.projects.settings.repository.create_deploy_token 1.39 MB 1.33 MB -51.32 KB -3.6 %
    pages.projects.settings.repository.show 1.39 MB 1.33 MB -51.32 KB -3.6 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@leipert, @markrian, @mikegreiling, @ohoral or @pgascouvaillancourt) for review, if you are unsure about the size increase.

    Note: We do not have exact data for 44dcadb7. So we have used data from: f257619d.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 0229380e

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Manage                             | 39     | 0      | 4       | 2     | 43    | ❗     |
    | Create                             | 28     | 0      | 1       | 0     | 29    | ✅     |
    | Plan                               | 49     | 0      | 1       | 0     | 50    | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Verify                             | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern                             | 13     | 0      | 5       | 1     | 18    | ❗     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 150    | 0      | 15      | 3     | 165   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Jiaan Louw added 1 commit

    added 1 commit

    Compare with previous version

  • Jiaan Louw marked this merge request as ready

    marked this merge request as ready

  • Jiaan Louw changed title from Draft: Resolve "Cube Query Rendering Widget - Table" to Add a cube analytics table visualization to product analytics

    changed title from Draft: Resolve "Cube Query Rendering Widget - Table" to Add a cube analytics table visualization to product analytics

  • Jiaan Louw marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Jiaan Louw
  • Jiaan Louw mentioned in merge request !105291 (merged)

    mentioned in merge request !105291 (merged)

  • Jiaan Louw
  • Jiaan Louw
  • Jiaan Louw
  • Jiaan Louw requested review from @agarciatesares

    requested review from @agarciatesares

  • Axel García
  • Axel García
  • Axel García
  • Axel García approved this merge request

    approved this merge request

  • Axel García removed review request for @agarciatesares

    removed review request for @agarciatesares

  • :wave: @agarciatesares, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • 🤖 GitLab Bot 🤖 added 1 deleted label

    added 1 deleted label

  • Jiaan Louw added 1 commit

    added 1 commit

    • d742bfd3 - Add todo comment to remove utility class once migrated

    Compare with previous version

  • Jiaan Louw requested review from @rob.hunt

    requested review from @rob.hunt

  • Jiaan Louw mentioned in merge request gitlab-ui!3191 (merged)

    mentioned in merge request gitlab-ui!3191 (merged)

  • Robert Hunt
  • Robert Hunt
  • Robert Hunt
  • Robert Hunt
  • Robert Hunt
    • Resolved by Jiaan Louw

      suggestion (non-blocking): The separation between the widget title and table headers feels a little too close :thinking:. WDYT about removing the headers top border or adding more space between the widget title and visualizations (or a combination of both)?

      Current Without top border With more spacing
      image image image
  • Robert Hunt removed review request for @rob.hunt

    removed review request for @rob.hunt

  • Jiaan Louw added 1 commit

    added 1 commit

    Compare with previous version

  • Jiaan Louw requested review from @rob.hunt

    requested review from @rob.hunt

  • Robert Hunt removed review request for @rob.hunt

    removed review request for @rob.hunt

  • Jiaan Louw added 1819 commits

    added 1819 commits

    • 475b49a3...44dcadb7 - 1814 commits from branch master
    • b3743509 - Add a cube analytics table visualization
    • e500393c - Add specs for data table
    • fc4466c8 - Add todo comment to remove utility class once migrated
    • 778c939d - Apply reviewer suggestions
    • 0229380e - Apply reviewer suggestion to table layout

    Compare with previous version

  • Jiaan Louw requested review from @rob.hunt

    requested review from @rob.hunt

  • Robert Hunt approved this merge request

    approved this merge request

  • Robert Hunt resolved all threads

    resolved all threads

  • Robert Hunt enabled an automatic merge when the pipeline for dc724447 succeeds

    enabled an automatic merge when the pipeline for dc724447 succeeds

  • merged

  • Robert Hunt mentioned in commit ecc512d9

    mentioned in commit ecc512d9

  • Jiaan Louw mentioned in merge request !105847 (merged)

    mentioned in merge request !105847 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading