Style `kbd`, `code` & `pre` elements in GFM"
What does this MR do and why?
Adjusts slightly the monospace elements kbd
, code
, pre
. In the current code version:
-
kbd
is changed from11px
to12px
and is slightly vertical adjusted -
code
is changed from12.6px
to14px
-
pre
is changed from13px
to14px
Screenshots or screen recordings
kbd
Before font-size 11px
|
After (new font) font-size 12px , adjusted vertical-align |
---|---|
![]() |
![]() |
code
Text before code
is 14px Inter
Before (90% font-size) - 12.6.px | After (new font) (90% font-size) - 12.6.px | After (new font) - 12px | After (new font) - 14px (![]() |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
pre
Before - font-size: 13px
|
After (new font) - font-size: 14px
|
---|---|
![]() |
![]() |
How to set up and validate locally
Follow the instructions from this MR to apply new fonts.
Insert the following code into the markdown field - e.g. I've used project's README. Go to any project page, update README file with the following content
# testing kbd, code, pre with new mono font
### kbd
<kbd>Ctrl</kbd>Key CTRL
### code
Some text before the code <code>console.log('test')</code>
### pre
<pre role="img" aria-label="ASCII COW">
___________________________
< I'm an expert in my field (pre example). >
---------------------------
\ ^__^
\ (oo)\_______
(__)\ )\/\
||----w |
|| ||
</pre>
Related to #381554 (closed)
Merge request reports
Activity
changed milestone to %15.7
assigned to @ohoral
added workflowin review label and removed workflowin dev label
- Resolved by Olena Horal-Koretska
@ohoral - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
- Resolved by Andrew Fontaine
@seggenberger I have slightly adjusted the elements sizes based on my tastes just to start discussing this. This is a follow-up from the typeface update MR which is not merged yet as we're still are figuring out what license files need to be included. But we can work on this follow-up meanwhile. Could you take a look, please? Code changes are minimal so I'm not assigning it for the dev review until we agree on the looks)
requested review from @seggenberger
added 1 commit
- 80998c08 - Adjusts slightly the monospace elements `kbd`, `code`, `pre`
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Alper Akgun (
@a_akgun
) (UTC+3, 1 hour ahead of@ohoral
)Justin Ho (
@justin_ho
) (UTC+7, 5 hours ahead of@ohoral
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 847ff9b6expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Manage | 38 | 1 | 4 | 6 | 43 | ❌ | | Plan | 49 | 0 | 1 | 0 | 50 | ✅ | | Govern | 15 | 0 | 5 | 3 | 20 | ❗ | | Create | 28 | 0 | 1 | 0 | 29 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 151 | 1 | 15 | 9 | 167 | ❌ | +------------------------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 80998c08expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 823 | 0 | 22 | 0 | 845 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Manage | 356 | 0 | 27 | 1 | 383 | ❗ | | Package | 144 | 0 | 37 | 2 | 181 | ❗ | | Verify | 229 | 0 | 42 | 0 | 271 | ✅ | | Plan | 312 | 0 | 0 | 0 | 312 | ✅ | | Fulfillment | 10 | 0 | 75 | 0 | 85 | ✅ | | Govern | 208 | 1 | 0 | 0 | 209 | ❌ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Secure | 30 | 0 | 10 | 7 | 40 | ❗ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Monitor | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 13 | 0 | 1 | 0 | 14 | ✅ | | Systems | 3 | 0 | 0 | 0 | 3 | ✅ | | Version sanity check | 0 | 0 | 7 | 5 | 7 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2177 | 1 | 242 | 15 | 2420 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
@seggenberger
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added typemaintenance label
added 1251 commits
-
80998c08...1dd388c2 - 1250 commits from branch
master
- e5fe13d6 - Adjusts slightly the monospace elements `kbd`, `code`, `pre`
-
80998c08...1dd388c2 - 1250 commits from branch
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits afa9acfd and 847ff9b6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 1.86 MB 1.94 MB +83.6 KB 4.4 % average 3.45 MB 3.5 MB +42.3 KB 1.2 % Significant Growth: 6Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.product_analytics.dashboards 906.44 KB 1.04 MB +156.72 KB 17.3 % pages.dashboard.milestones.show 616.6 KB 682.8 KB +66.2 KB 10.7 % pages.projects.branches.index 1.03 MB 1.07 MB +35.08 KB 3.3 % pages.groups.observability.dashboards 105.65 KB 117.19 KB +11.53 KB 10.9 % pages.groups.observability.explore 105.65 KB 117.19 KB +11.53 KB 10.9 % pages.groups.observability.manage 105.65 KB 117.19 KB +11.53 KB 10.9 % New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.web_ide.remote_ide 0 Bytes 6.62 KB +6.62 KB 100.0 % Significant Reduction: 181Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.ci_cd.show 2.93 MB 2.73 MB -206.53 KB -6.9 % pages.projects.licenses.index 2.24 MB 2.05 MB -199.65 KB -8.7 % pages.projects.settings.merge_requests 2.19 MB 2.06 MB -126.73 KB -5.7 % pages.projects.settings.repository.create_deploy_token 1.39 MB 1.26 MB -125.95 KB -8.9 % pages.projects.settings.repository.show 1.39 MB 1.26 MB -125.95 KB -8.9 % pages.projects.cluster_agents.show 2.37 MB 2.28 MB -90.84 KB -3.7 % pages.projects.shared.web_ide_link 991.92 KB 910.67 KB -81.25 KB -8.2 % pages.groups.registry.repositories 1.26 MB 1.19 MB -75.56 KB -5.9 % pages.projects.registry.repositories 1.43 MB 1.36 MB -75.56 KB -5.2 % pages.groups.issues 2.1 MB 2.03 MB -75.22 KB -3.5 % The table above is limited to 10 entries. Please look at the full report for more details
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@mikegreiling
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for afa9acfd. So we have used data from: f257619d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 323 commits
-
e5fe13d6...6bc2eb67 - 322 commits from branch
master
- 74b76f59 - Adjusts slightly the monospace elements `kbd`, `code`, `pre`
-
e5fe13d6...6bc2eb67 - 322 commits from branch
added 715 commits
-
74b76f59...e3e8bce2 - 714 commits from branch
master
- 103664a6 - Adjusts slightly the monospace elements `kbd`, `code`, `pre`
-
74b76f59...e3e8bce2 - 714 commits from branch
added typefeature label and removed typemaintenance label
requested review from @jrushford
requested review from @afontaine and removed review request for @jrushford
added 1 commit
- 847ff9b6 - Adjusts slightly the monospace elements `kbd`, `code`, `pre`
Looks great @ohoral!
Thank you @afontaine
enabled an automatic merge when the pipeline for cbf867f1 succeeds
mentioned in commit 4c483778
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !142882 (merged)