Track allowed Redis cross-slot operations
What does this MR do and why?
This MR adds the functionality to track allowed cross-slot commands. This functionality is controlled using a feature-flag. To enable this, the MR also refactors lib/gitlab/instrumentation/redis_cluster_validator.rb
to return a result
hash instead of raising CrossSlotError
. The hash containing metadata will allow the instrumentation layer to handle errors and logs/metrics.
Since redis_base.rb
is the only user of redis_cluster_validator
, there is no behavioural change beyond those 2 classes.
See main issue: gitlab-com/gl-infra/scalability#2005
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.