Add GRAPHQL option to ScanMethodTypeEnum
What does this MR do and why?
This Merge Request adds the GRAPHQL
option to ScanMethodTypeEnum.
This change is necessary to allow the creation of dast site profiles
with GraphQL scan method as described in #378692 (closed).
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
-
Go to
/-/graphql-explorer
-
Create a query like
mutation dastSiteProfileCreate($input: DastSiteProfileCreateInput!) {
dastSiteProfileCreate(input: $input) {
errors
dastSiteProfile {
id
}
}
}
{
"input": {
"fullPath": "root/apiscantest",
"profileName": "Test GraphQL",
"scanMethod": "GRAPHQL",
"targetType": "API",
"targetUrl": "http://localhost"
}
}
- Check the result
{
"data": {
"dastSiteProfileCreate": {
"errors": [],
"dastSiteProfile": {
"id": "gid://gitlab/DastSiteProfile/15"
}
}
}
}
- Check the new record via rails console
rails c
DastSiteProfile.last
DastSiteProfile Load (1.1ms) SELECT "dast_site_profiles".* FROM "dast_site_profiles" ORDER BY "dast_site_profiles"."id" DESC LIMIT 1
=> #<DastSiteProfile:0x0000000127b3f588
id: 15,
project_id: 20,
dast_site_id: 9,
created_at: Mon, 28 Nov 2022 20:43:05.485958000 UTC +00:00,
updated_at: Mon, 28 Nov 2022 20:43:05.485958000 UTC +00:00,
name: "Test GraphQL",
excluded_urls: [],
auth_enabled: false,
auth_url: nil,
auth_username_field: nil,
auth_password_field: nil,
auth_username: nil,
target_type: "api",
scan_method: "graphql",
auth_submit_field: nil,
scan_file_path: "http://localhost">
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.7
assigned to @mc_rocha
- A deleted user
added backend documentation labels
1 Warning Please add a merge request subtype to this merge request. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michael Becker (
@wandering_person
) (UTC-8, 8 hours behind@mc_rocha
)Stan Hu (
@stanhu
) (UTC-8, 8 hours behind@mc_rocha
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
requested review from @philipcunningham
mentioned in issue #378692 (closed)
- Resolved by Patrick Bajao
removed review request for @philipcunningham
@philipcunningham
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 209da566 succeeds
mentioned in commit d7d74a3c
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)