Skip to content

Remove secure_files_metadata_parsers feature flag

Darby Frey requested to merge remove_secure_files_metadata_parsers_feature_flag into master

What does this MR do and why?

This MR completes the rollout of the secure_files_metadata_parsers feature by removing the feature flag.

Feature flag rollout issue: #383284 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  1. Enabled the Feature Flags (in the rails console)
Feature.enable(:ci_secure_files)
  1. Upload sample files in Secure Files. In the project settings section:
  • On the left sidebar, select Settings > CI/CD.
  • In the Secure Files section, select Expand.
  • Select Upload File.
  • Browse to the gitlab project and upload files in gitlab/spec/fixtures/ci_secure_files/sample.cer, gitlab/spec/fixtures/ci_secure_files/sample.p12, and gitlab/spec/fixtures/ci_secure_files/sample.mobileprovision
  1. In a rails console, look up the recently uploaded files to ensure the metadata attributes contains the file metadata.
file = Ci::SecureFile.last
file.metadata # should contain a hash of metadata

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Darby Frey

Merge request reports