Show comments inline for GFM links
What does this MR do and why?
Inline preview of comments in GFM (#29663 (closed))
How to test
- enable
inline_note_previewsfeature flag - On an issue (description or a comment), add a link to a comment
- Click the link to the comment
- Comment expands below your text
- Click link again to collapse comment
Other notes
- Missing some small layout things (like user avatar)
- Link as toggle is a bit weird UI-wise
Tried using popovers and had some issues:
- Doesn't truncate, could lead to giant popovers
- circular popovers
- diagrams and things didn't render nicely
Edited by Simon Knox