WIP: Generate correct link when listing protected environments.
What does this MR do?
When listing protected environments on the CI/CD settings page the generated urls are using the protected_environments.name
instead of the environments.id
and this results in 404 error when following the link.
This MR is fixing this by changing the way protected environments are fetched from the database to JOIN
with the environments table so that the environments.id
can be selected and available in the view partial.
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/58706
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer