Skip to content

Add pwa_logos and dynamically load them to manifest.json

Andreas Deicha requested to merge siemens/gitlab:feature/dynamic_manifest_pwa_logo into master

What does this MR do and why?

Fixes partially #375708 (closed)

First MR !104079 (merged)

Makes logos in manifest.json loading dynamicly

Screenshots or screen recordings

manifest.json in browser:

image image

How to set up and validate locally

  1. Open your local GitLab instance
  2. Click f12 and inspect manifest.json in application tab
  3. You should see default values for the titles, logos and so on
  4. Change your Appearance settings as explained here, for logo 
curl --location --request PUT "https://gitlab.example.com/api/v4/application/appearance?data=image/png" \
--header "Content-Type: multipart/form-data" \
--header "PRIVATE-TOKEN: <your_access_token>" \
--form "logo=@/path/to/logo.png"
  1. Reload your browser and recheck the manifest
  2. You should see the logo in the appropriate size.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

🛠 with ❤ at Siemens

Edited by Andreas Deicha

Merge request reports