Skip to content

DurationChart: Remove unneeded show-toolbox props

Laurent Deketelaere requested to merge ali_o_kan/gitlab:duration_chart-remove-unneeded-show-toolbox-props into master

What does this MR do and why?

What: Remove unneeded show-toolbox props on GlLineChart in /ee/app/assets/javascripts/analytics/cycle_analytics/components/duration_chart.vue

Why: show-toolbox props is optional and set to false by default, this code has no effect.

Moreover, it's a blocker to remove the ToolboxMixin in gitlab-ui (gitlab-ui!3167 (merged)), this is the only usage found of show-toolbox in the project.

Screenshots or screen recordings

No visible changes

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Laurent Deketelaere

Merge request reports