Move and rename Sentry constants
What does this MR do and why?
This change refactors our Sentry constants so they can be reused.
It also renames one of them to use the naming as newer versions of Sentry
I've split this change into different MRs, to make it easier to review:
Remove unusable Sentry feature flag (!104231 - merged) | about to be merged! |
Move and rename Sentry constants (!104247 - merged) | you are here ![]() |
Install two versions of Sentry Client SDK (!102790 - merged) | the big one! |
Screenshots or screen recordings
NA
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mrincon
changed milestone to %15.6
- A deleted user
added frontend label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Most of the time, merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Laura Meckley (
@lmeckley
) (UTC-7, 8 hours behind@mrincon
)Natalia Tepluhina (
@ntepluhina
) (UTC+1, same timezone as@mrincon
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@mrincon - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
mentioned in merge request !104231 (merged)
mentioned in merge request !102790 (merged)
added maintenancerefactor typemaintenance labels
- Resolved by Natalia Tepluhina
@ntepluhina can you help me review this change? It's a small change so I've skipped the first review. It all makes sense when looking at the next MR, I added the explanation in the description. Thanks!
requested review from @ntepluhina
added WorkingGroupFrontendObservability label
@ntepluhina
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
removed review request for @ntepluhina
@ntepluhina The upstream MR is merged, could you have another look?
requested review from @ntepluhina
mentioned in commit de38a953
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request !105323 (closed)
mentioned in merge request !105324 (merged)
added releasedpublished label and removed releasedcandidate label