Add job artifacts API to OpenAPIv2
What does this MR do and why?
Add job artifacts API to OpenAPIv2 documentation.
Descriptions and parameters are updated to be conistent with https://docs.gitlab.com/ee/api/job_artifacts.html.
Screenshots or screen recordings
Example OpenAPIv2 containing only job artifacts API can be found in this snippet.
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #376873
Merge request reports
Activity
changed milestone to %Next 1-3 releases
assigned to @alberts-gitlab
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jon Jenkins (
@jon_jenkins
) (UTC-6, 14 hours behind@alberts-gitlab
)Patrick Bajao (
@patrickbajao
) (UTC+8, same timezone as@alberts-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Sam Kim
@marcel.amirault could you help to review please? In particular, I added the optional parameter
job_token
that is only for Premium (see this commit). I'm not sure if this is the right way to document them, or how we should document it otherwise?@samsam_kim could you do the backend review please?
requested review from @marcel.amirault and @samsam_kim
- Resolved by Albert
added Technical Writing UI text labels
removed documentation label
removed review request for @marcel.amirault
requested review from @marcel.amirault
added 284 commits
-
ad2b7d20...8eb4a502 - 283 commits from branch
master
- be8e9f2c - Add job artifacts api to OpenAPI
-
ad2b7d20...8eb4a502 - 283 commits from branch
- Resolved by Marcel Amirault
removed review request for @marcel.amirault
- Resolved by Sam Kim
removed review request for @samsam_kim
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added 879 commits
-
e3d0f9f3...764f0a5a - 878 commits from branch
master
- 6bf29572 - Add job artifacts api to OpenAPI
-
e3d0f9f3...764f0a5a - 878 commits from branch
@lulalala could you take the maintainer review please?
requested review from @lulalala
- Resolved by Sincheol (David) Kim
LGTM, but I don't understand how
job_token
is used here.@alberts-gitlab could you explain?
Hi @alberts-gitlab I'll pass to dskim_gitlab for maintainer review.
requested review from @alberts-gitlab and removed review request for @lulalala
removed review request for @alberts-gitlab
- Resolved by Sincheol (David) Kim
@dskim_gitlab could you take the maintainer review please?
requested review from @dskim_gitlab
@dskim_gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for fe94d0e8 succeeds
mentioned in commit de64e855
added Category:Build Artifacts workflowstaging-canary labels and removed Category:Build Artifacts workflowin dev labels
added workflowcanary label and removed workflowstaging-canary label
added Category:Build Artifacts workflowstaging labels and removed Category:Build Artifacts workflowcanary labels
added workflowproduction label and removed workflowstaging label
added Category:Build Artifacts workflowpost-deploy-db-staging labels and removed Category:Build Artifacts workflowproduction labels
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1748 (merged)