Skip to content

Fix order dependency issue in GraphQL vulnerable type spec

Peter Leitzen requested to merge pl-spec-graphql-vuln-type into master

What does this MR do and why?

This MR fixes a bug where ee/spec/graphql/types/vulnerability_type_spec.rb failed when run in random (or reverse) order.

Done via scripts/rspec_check_order_dependence ./ee/spec/graphql/types/vulnerability_type_spec.rb.

Contributes to #382714 (closed).

How to set up and validate locally

See #382714 (comment 1172614108)

# After
RSPEC_ORDER=reverse bin/rspec ./ee/spec/graphql/types/vulnerability_type_spec.rb
rspec './ee/spec/graphql/types/vulnerability_type_spec.rb[1:7:1:1,1:7:2:1]' --seed 21662

# Before
git checkout master -- ./ee/spec/graphql/types/vulnerability_type_spec.rb

RSPEC_ORDER=reverse bin/rspec ./ee/spec/graphql/types/vulnerability_type_spec.rb
rspec './ee/spec/graphql/types/vulnerability_type_spec.rb[1:7:1:1,1:7:2:1]' --seed 21662

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brian Williams

Merge request reports